Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
danken at redhat.com
danken at redhat.com
Mon Mar 21 10:11:41 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards
......................................................................
Patch Set 6:
(4 comments)
https://gerrit.ovirt.org/#/c/54555/6/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:
Line 211:
Line 212:
Line 213: def enable_ipv6(device_name, enable=True, await_device=False):
Line 214: if ipv6_supported():
Line 215: if await_device:
have you not agreed that there is no need to wait for the device to be up?
Line 216: wait_for_device(device_name)
Line 217: # In broken networks, the device may be missing.
Line 218: with _pretend_path_exists():
Line 219: sysctl.disable_ipv6(device_name, disable=not enable)
https://gerrit.ovirt.org/#/c/54555/6/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:
Line 532
Line 533
Line 534
Line 535
Line 536
> There was a name conflict to begin with.
sorry, I do not understand your response.
Line 767: iface
> Done
come to think of that, how about adding a new function
_exec_ifup_name
because the suggested semantics is a bit too complex.
https://gerrit.ovirt.org/#/c/54555/6/lib/vdsm/network/models.py
File lib/vdsm/network/models.py:
Line 73: def backing_device(self):
Line 74: return False
Line 75:
Line 76: @property
Line 77: def top_level_device(self):
> No, it was still used in ifcfg in this version of the patch.
why? haven't we decided to treat each device independently?
Line 78: return self.master.top_level_device if self.master else self
Line 79:
Line 80:
Line 81: class Nic(NetDevice):
--
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list