Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
danken at redhat.com
danken at redhat.com
Mon Mar 21 07:00:36 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards
......................................................................
Patch Set 6: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/54555/6/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:
Line 223: _pretend_path_exists
_ignore_missing_device() is clearer
https://gerrit.ovirt.org/#/c/54555/6/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:
Line 532
Line 533
Line 534
Line 535
Line 536
this changes seems to deserve its own patch and commit message; to me it seems not directly related.
Line 767: iface
"if iface is not None" is more precise.
Please document in docstring the now-complex logic of this function.
https://gerrit.ovirt.org/#/c/54555/6/lib/vdsm/network/models.py
File lib/vdsm/network/models.py:
Line 73: def backing_device(self):
Line 74: return False
Line 75:
Line 76: @property
Line 77: def top_level_device(self):
leftover from former version?
Line 78: return self.master.top_level_device if self.master else self
Line 79:
Line 80:
Line 81: class Nic(NetDevice):
--
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list