Change in vdsm[master]: hooks:checkips: add checkips hook

danken at redhat.com danken at redhat.com
Mon Mar 21 06:50:13 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/README
File vdsm_hooks/checkips/README:

Line 28: Usage:
Line 29:     In the host setup network configuration window, choose edit assigned
Line 30:     logical network, select custom property checkipv4 or checkipv6 and enter VLAN IP or FQDN
Line 31:     that you want check for connectivity(example 127.0.0.1,::1). If IP does
Line 32:     not connective from host, it will drop host to non-operational state.
> But if I understand correct the bug, user interested in connectivity betwee
It not that an "and" logic is wrong; I just think that if one of the target hosts is down, but the other is still accessible, it's probably the fault of the target host and not our own host.

If you feel very strongly for "and", you can document and implement it. My own gut feeling is for "or" for the mean while.


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list