Change in vdsm[master]: hooks:checkips: add checkips hook

alukiano at redhat.com alukiano at redhat.com
Sun Mar 20 20:37:18 UTC 2016


Artyom Lukianov has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54102/5/vdsm_hooks/checkips/README
File vdsm_hooks/checkips/README:

Line 28: Usage:
Line 29:     In the host setup network configuration window, choose edit assigned
Line 30:     logical network, select custom property checkipv4 or checkipv6 and enter VLAN IP or FQDN
Line 31:     that you want check for connectivity(example 127.0.0.1,::1). If IP does
Line 32:     not connective from host, it will drop host to non-operational state.
> I'm for OR logic: if one or more of the target IPs is reachable, it means t
But if I understand correct the bug, user interested in connectivity between host to specific IP, so if he provided both custom properties he wants to be sure that both of them are connective from host.
about implementation I can just add type of address to network name: ovirtmgmt_ipv4 and ovirtmgmt_ipv6 and check modification time of both files
but anyway if you think it redundant now I can add it in the future)


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list