Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

danken at redhat.com danken at redhat.com
Sun Mar 20 19:09:25 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54130/3/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 157
Line 158
Line 159
Line 160
Line 161
even though this function has become so much simpler, I think that it makes sense to keep it. In-lining the logic complicates things for me.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list