Change in vdsm[master]: contrib: schema converter

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Sat Mar 19 18:21:30 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 22:

(2 comments)

https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 333:     symbol.update({'name': name, 'info_data': {}, 'info_return': '',
Line 334:                    'xxx': []})
Line 335: 
Line 336:     # Pop a blank line
Line 337:     assert('' == lines.pop(0))
> asserts must not have side effects, since they are eliminated when running 
Done
Line 338: 
Line 339:     # Grab the entity description.  It might span multiple lines.
Line 340:     symbol['desc'] = lines.pop(0)
Line 341:     while (lines[0] != ''):


Line 341:     while (lines[0] != ''):
Line 342:         symbol['desc'] += lines.pop(0)
Line 343: 
Line 344:     # Pop a blank line
Line 345:     assert ('' == lines.pop(0))
> Same
Done
Line 346: 
Line 347:     # Populate the rest of the human-readable data.
Line 348:     # First try to read the parameters/members information.  We are finished
Line 349:     # once we read a <tag>: line.  After reading a 'Returns:' tag, we will try


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list