Change in vdsm[master]: hostdev: decode XML string when parsing devices

danken at redhat.com danken at redhat.com
Sat Mar 19 08:16:53 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hostdev: decode XML string when parsing devices
......................................................................


hostdev: decode XML string when parsing devices

As there is no encoding of information and libvirt does not handle
encoding, our best bet is ascii. This patch therefore converts device
XMLs to ascii, ignoring the errors found.

Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Bug-Url: https://bugzilla.redhat.com/1315435
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54802
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/hostdev.py
M tests/devices/data/Makefile.am
A tests/devices/data/computer.xml
M tests/hostdevTests.py
M tests/vmfakelib.py
5 files changed, 32 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list