Change in vdsm[master]: osinfo: avoid excepting *

danken at redhat.com danken at redhat.com
Fri Mar 18 12:27:46 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: osinfo: avoid excepting *
......................................................................


osinfo: avoid excepting *

Using 'except:' can easily hide things such as syntax errors. This
patch changes the code to except Exceptions, leading to possibly safer
code.

Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54545
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M lib/vdsm/osinfo.py
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list