Change in vdsm[master]: contrib: schema converter
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Fri Mar 18 07:54:28 UTC 2016
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
......................................................................
Patch Set 22:
(2 comments)
https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter
File contrib/schema-converter:
Line 170: return maps
Line 171:
Line 172:
Line 173: def convert_unions(symbol):
Line 174: # need to fix description
> what's wrong with the description?
It looks like stale comment. Will remove.
Line 175: unions = {}
Line 176: for content in symbol.values():
Line 177: if 'union' not in content.keys():
Line 178: continue
https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:
Line 87
Line 88
Line 89
Line 90
Line 91
> Why is this change needed?
Yaniv asked for py3 support so I discovered that it is not working with py3 due to this line.
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list