Change in vdsm[master]: hooks:checkips: add checkips hook

alukiano at redhat.com alukiano at redhat.com
Thu Mar 17 23:56:50 UTC 2016


Artyom Lukianov has posted comments on this change.

Change subject: hooks:checkips: add checkips hook
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/54102/3/vdsm_hooks/checkips/checkips_utils.py
File vdsm_hooks/checkips/checkips_utils.py:

Line 25: 
Line 26: def touch(address, net, file_dir):
Line 27:     file_name = '{net}_{address}'.format(net=net, address=address)
Line 28:     file_path = os.path.join(file_dir, file_name)
Line 29:     with open(file_path, 'a'):
> oops, I thought you were appending text to it. there is no need for both op
open func only open file and does not really modify it, but I still need it, because when I want to modify file first time ,file does not exist, so open() create it
Line 30:         os.utime(file_path, None)
Line 31: 
Line 32: 
Line 33: def parse_addresses(params):


-- 
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list