Change in vdsm[master]: vm: Move saveState() out of constructor
mbetak at redhat.com
mbetak at redhat.com
Thu Mar 17 17:26:45 UTC 2016
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 686: self._vmStartEvent.set()
Line 687: return
Line 688:
Line 689: self._vmStartEvent.set()
Line 690: self.saveState()
> Dan pointed out that we to make sure this is in the sync path. So, it shoul
Done
Line 691: try:
Line 692: self.memCommit()
Line 693: with self._ongoingCreations:
Line 694: self._vmCreationEvent.set()
--
To view, visit https://gerrit.ovirt.org/53950
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb38fdc06bf1a7b881cd64d2af45a93b16c935ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list