Change in vdsm[master]: migration: Add DynamicThrottling semaphores

fromani at redhat.com fromani at redhat.com
Thu Mar 17 16:02:57 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/53304/11/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 157: 
Line 158:     def __exit__(self, exc_type, exc_val, exc_tb):
Line 159:         self.release()
Line 160: 
Line 161:     def set_bound(self, value):
> I'm considering if it wouldn't be nicer if the bound was a property with th
I lean towards the property
Line 162:         """ Dynamically updates semaphore bound.
Line 163: 
Line 164:         When the the specified value is larger than the previous bound,
Line 165:         it releases the semaphore the required number of times (and possibly


-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list