Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 17 12:54:59 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
......................................................................


Patch Set 2:

(1 comment)

I like this very much, great idea!

https://gerrit.ovirt.org/#/c/54856/2/.travis.yml
File .travis.yml:

Line 7:   - docker --version
Line 8:   - docker pull edwardhaas/ovirt-vdsm-dev
Line 9: 
Line 10: script:
Line 11:   - docker run  edwardhaas/ovirt-vdsm-dev
This gives us no control for running the tests, for example:
- Which branch to pull
- What test to run

It would be better that we control this from the yaml, instead of hard coding this in a script inside the container.

Regarding the branch - this should pull the current branch in github, so we can run this on our private github forks. This would allow someone to clone the project, push a new branch, and get the tests running in travis *before* the patch is sent or merge to ovirt.

Regarding the command, it would be best to have here the make command (e.g, make check-xxx)


-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaro at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list