Change in vdsm[master]: monitoring: Separate storage health monitoring

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 16 23:53:25 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: monitoring: Separate storage health monitoring
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/54757/6/lib/vdsm/storage/check.py
File lib/vdsm/storage/check.py:

Line 146:         Called when dd process has closed stderr. At this point the process may
Line 147:         be still running.
Line 148:         """
Line 149:         self._reader = None
Line 150:         self._stats = data.splitlines()[-1]
- This breaks when dd fails with no ouput
- needs parsing from misc.readspeed.
Line 151:         rc = self._proc.poll()
Line 152:         if rc is None:
Line 153:             self._reaper = Reaper(self._loop, self._proc, self._check_completed)
Line 154:             return


-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list