Change in vdsm[master]: net: abstact rollback handler as netswitch.RollbackManager

phoracek at redhat.com phoracek at redhat.com
Wed Mar 16 14:39:30 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: abstact rollback handler as netswitch.RollbackManager
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54815/2/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 115: 
Line 116:     :returns: the top object of the hierarchy.
Line 117:     """
Line 118:     if configurator is None:
Line 119:         configurator = RollbackManager()
this is ugly, just because of the name, ConfiguratorClass contained the same, but here it is obvious.
Line 120:     if _netinfo is None:
Line 121:         _netinfo = CachingNetInfo()
Line 122:     if opts is None:
Line 123:         opts = {}


-- 
To view, visit https://gerrit.ovirt.org/54815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01a71999649d3a37ee33818483b3a2a55db0270b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list