Change in vdsm[master]: check: Separate storage health monitoring

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 16 10:44:06 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: check: Separate storage health monitoring
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54757/2/lib/vdsm/storage/check.py
File lib/vdsm/storage/check.py:

Line 171:         self.complete(self.data)
Line 172:         self.complete = None
Line 173: 
Line 174:     def close(self):
Line 175:         # asyncore.dispatcher define closing attribute, but doe not use it.
doe -> does
Line 176:         if self.closing:
Line 177:             return
Line 178:         self.closing = True
Line 179:         asyncore.file_dispatcher.close(self)


-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list