Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Mar 16 08:58:54 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
......................................................................


Patch Set 15:

(2 comments)

https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File lib/vdsm/exception.py:

Line 121:     code = 19
Line 122:     message = 'Guest agent non-responsive'
Line 123: 
Line 124: 
Line 125: # codes 20-35 are reserved for add/delNetwork
> Pitor, we should think how can e generate the engine side from this module,
Yes, this is part of external interface. In ideal world it would the goal to generate client side codes from server side modules.

I want to get there.
Line 126: # code 39 was used for:
Line 127: # wrongHost - migration destination has an invalid hostname
Line 128: 
Line 129: 


Line 221:     code = 58
Line 222:     message = 'Wrong resize disk parameter'
Line 223: 
Line 224: 
Line 225: class TransientError(VdsmException):
> We should add it to engine, or remove it from this file, but we can do this
If there is no code in the client it would handle it as generic issue.
Line 226:     code = 59
Line 227:     message = 'Action not permitted on a VM with transient disks'
Line 228: 
Line 229: 


-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list