Change in vdsm[master]: tests: Provide dnsmasq_run as a context manager
danken at redhat.com
danken at redhat.com
Tue Mar 15 19:55:56 UTC 2016
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Provide dnsmasq_run as a context manager
......................................................................
tests: Provide dnsmasq_run as a context manager
The functional tests are using dnsmasqDhcp as the dnsmasq context
manager. It is limited to a single configuration and located as part of
the functional network test module.
Same functionality has been added in the nettestlib module, with options
to allow a test to specify its own configuration, per the needs.
dnsmasqDhcp is replaced by dnsmasq_run.
Change-Id: Ifde1232416081981256c3e384151574617e9b0d0
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54632
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček <phoracek at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M tests/functional/networkTestsOVS.py
M tests/network/nettestlib.py
3 files changed, 48 insertions(+), 30 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/54632
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifde1232416081981256c3e384151574617e9b0d0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
More information about the vdsm-patches
mailing list