Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

edwardh at redhat.com edwardh at redhat.com
Tue Mar 15 16:28:41 UTC 2016


Edward Haas has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 100:             self.runningConfig.save()
Line 101:             self.runningConfig = None
Line 102: 
Line 103:     def configureBridge(self, bridge, **opts):
Line 104:         if bridge.ipv6.requested:
> By such a rule, non-top level devices that would "naturally" get an IPv6LL 
As I see it, if no IPv6 has been set for a network, none of its devices should have IPv6 at all, not even link scope addresses.
The logic from my side is this: If IPv6 was not mentioned, it should be disabled. Or another way to put it, based on how ifcfg configures the interface: If ipv6 was not mentioned, IPV6INIT=no, and when that is the case, IPv6 should be disabled.

I understand your point on this, especially with the bridge example.
Lets see what is Dan take on this.
Line 105:             enable_ipv6(bridge.name)
Line 106:         self.configApplier.addBridge(bridge, **opts)
Line 107:         ifdown(bridge.name)
Line 108:         if bridge.port:


-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list