Change in vdsm[master]: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py

danken at redhat.com danken at redhat.com
Tue Mar 15 11:09:26 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
......................................................................


virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py

This is a preparation step for the next round of moving device handling
code out of Vm class.  We want to move Vm._getUnderlying* methods out of
Vm, but not all at once.  Most of the methods use
_getUnderlyingDeviceAddress() so we need to have this functionality
available in both Vm and the moved code and this is the reason for
having this preparation step.

Change-Id: Ib9868ca1df6650b1262e6f30d639a08b1f38304d
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53615
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
2 files changed, 33 insertions(+), 33 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/53615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9868ca1df6650b1262e6f30d639a08b1f38304d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list