Change in vdsm[master]: net: Network caps now reports IPv6 autoconf state

edwardh at redhat.com edwardh at redhat.com
Tue Mar 15 09:40:18 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: Network caps now reports IPv6 autoconf state
......................................................................


Patch Set 9:

(3 comments)

https://gerrit.ovirt.org/#/c/54475/9/lib/vdsm/netinfo/addresses.py
File lib/vdsm/netinfo/addresses.py:

Line 29: 
> why dont we just import is as it is and place is_ipv6_local_auto here?
Because sysctl is the implementation and netinfo.addresses is the 'api'.
The implementation can change to netlink for example.

At least this is how I see it.


https://gerrit.ovirt.org/#/c/54475/9/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:

Line 55: is_disable
> is_disable -> is_disabled
Done


Line 56:         with open('/proc/sys/net/ipv6/conf/%s/autoconf' % dev) as f:
> /proc/sys/net/ipv6/conf/%s/%s begs for constant
What advantage will it have? It will not make it shorter or more readable IMO.

And as its all over this file, I guess we can do it in a separated patch for all the rest if you think its better.


-- 
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If91083ec3502a2679328e92aa63699d16c77df71
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list