Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Mar 15 08:30:10 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
......................................................................


Patch Set 15:

(3 comments)

https://gerrit.ovirt.org/#/c/48871/15/lib/vdsm/exception.py
File lib/vdsm/exception.py:

Line 225: TransientError
> Does Engine use this code for something else or it is just absent? Same for
The code is not there.


Line 260: NoSuchJob
> This (and 68, 69) are probably the old name, the job management start tailo
Maybe we need to update engine side


Line 300: SecretUnregistrationFailed
> We probably missed them when we added the secrets api back in time. Should 
We need to make sure that we have the same values there. I will push a patch to fix it.


-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list