Change in vdsm[master]: lib: executor: port executor.py to python3

fromani at redhat.com fromani at redhat.com
Tue Mar 15 07:54:43 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: lib: executor: port executor.py to python3
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/54576/4//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: lib: executor: port executor.py to python3
Line 8: 
Line 9: This patch fixes executor.py to work with python3
Line 10: using 'six', and enable its test to run on python3.
> You can update the commit message about using range which is supported on b
Done
Line 11: 
Line 12: Change-Id: I3b768b4a7f297f59376e005b4abab3a328bf4b50


https://gerrit.ovirt.org/#/c/54576/4/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 70:         with self._lock:
Line 71:             if self._running:
Line 72:                 raise AlreadyStarted()
Line 73:             self._running = True
Line 74:             for _ in range(self._workers_count):
> workers count is a small number (if you create a high worker count, you hav
Keeping 'range' for the time being
Line 75:                 self._add_worker()
Line 76: 
Line 77:     def stop(self, wait=True):
Line 78:         self._log.debug('Stopping executor')


-- 
To view, visit https://gerrit.ovirt.org/54576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b768b4a7f297f59376e005b4abab3a328bf4b50
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list