Change in vdsm[master]: tests: refactor manifest_tests fake env setup

alitke at redhat.com alitke at redhat.com
Mon Mar 14 19:59:16 UTC 2016


Adam Litke has posted comments on this change.

Change subject: tests: refactor manifest_tests fake env setup
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/50273/4/tests/domain_manifest_test.py
File tests/domain_manifest_test.py:

Line 134
Line 135
Line 136
Line 137
Line 138
> So we actually remove this test, right?
Oops.  Rebase error removed it.  Adding it back.


Line 65: 
Line 66:     def test_getmetaparam(self):
Line 67:         with fake_file_env() as env:
Line 68:             sd_manifest = env.sd_manifest
Line 69:             sd_manifest._metadata[sd.DMDK_SDUUID] = sd_manifest.sdUUID
> Why do need to set this like this?
Actually this is no longer needed due to 8559f59 .
Line 70:             self.assertEquals(sd_manifest.sdUUID,
Line 71:                               sd_manifest.getMetaParam(sd.DMDK_SDUUID))
Line 72: 
Line 73:     def test_getallimages(self):


Line 105:                              env.sd_manifest.getVSize('<imgUUID>', lv_name))
Line 106: 
Line 107:     def test_getmetaparam(self):
Line 108:         with fake_block_env() as env:
Line 109:             env.sd_manifest._metadata[sd.DMDK_SDUUID] = env.sd_manifest.sdUUID
> Same
My comment from above also applies here.
Line 110:             self.assertEquals(env.sd_manifest.sdUUID,
Line 111:                               env.sd_manifest.getMetaParam(sd.DMDK_SDUUID))
Line 112: 
Line 113:     def test_getblocksize_defaults(self):


-- 
To view, visit https://gerrit.ovirt.org/50273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74b82ffaa34d6df68e1531735cc776e4de23f95c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list