Change in vdsm[master]: storagetests: initial FakeEnv support

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 14 19:40:29 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: storagetests: initial FakeEnv support
......................................................................


storagetests: initial FakeEnv support

Many storage tests rely on a mocked storage environment in order to test
the storage code.  We can achieve this environment through a combination
of mocked objects, monkey-patching, and use of temporary files and
directories.  To simplify the tests and increase reliability we
introduce a standardized interface implemented with context managers
that can be used by all tests.  While not all tests actually require the
full scope of these mocked environments, the benefits of uniformity
justify the extra setup.

Change-Id: I23c27ad8f642639852796ab98fb102dedf55aedd
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54567
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M tests/storagetestlib.py
1 file changed, 36 insertions(+), 2 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23c27ad8f642639852796ab98fb102dedf55aedd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list