Change in vdsm[master]: net tests: IPv6 autoconf with RA server

danken at redhat.com danken at redhat.com
Mon Mar 14 16:56:36 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net tests: IPv6 autoconf with RA server
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/54668/3/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:

Line 417: ddresses.getIpAddrs()[client]
add sorted() around this to have a consistent order below


Line 423: 2001::1
I am confused. Shouldn't the prefix be '2001:0:0:1' ?

The repeated use of '2001::1' and '2001:0:0:1' merits a named constant.


Line 420:                 # The global address is also the dynamic one
Line 421:                 # The addresses are given randomly, so we check the order
Line 422:                 if addresses.is_dynamic(ip_addrs[0]):
Line 423:                     self.assertEqual('2001::1', ip_addrs[0]['address'][:7])
Line 424:                     self.assertEqual('fe80', ip_addrs[1]['address'][:4])
it might be nicer to check

netaddr.IPAddress(ip_addrs[1]['address']).is_link_local()
Line 425:                 else:
Line 426:                     self.assertEqual('2001::1', ip_addrs[1]['address'][:7])


-- 
To view, visit https://gerrit.ovirt.org/54668
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c153adf7d27db0151a330f55719622a8f730a9b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list