Change in vdsm[master]: storage: Cleanup usage of DMDK_POOLS

alitke at redhat.com alitke at redhat.com
Mon Mar 14 15:51:09 UTC 2016


Adam Litke has posted comments on this change.

Change subject: storage: Cleanup usage of DMDK_POOLS
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/54564/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 38: import clusterlock
Line 39: import outOfProcess as oop
Line 40: from persistentDict import unicodeEncoder, unicodeDecoder
Line 41: import volume
Line 42: import vdsm.storage.constants as storage_constants
> Lets use the standard form:
Done
Line 43: 
Line 44: from vdsm.config import config
Line 45: 
Line 46: DOMAIN_MNT_POINT = 'mnt'


https://gerrit.ovirt.org/#/c/54564/2/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 22: import logging
Line 23: import time
Line 24: from contextlib import contextmanager
Line 25: 
Line 26: import vdsm.storage.constants as storage_constants
> Use from vdsm.storage... and group with other "from vdsm.storage..." import
Done
Line 27: import image
Line 28: 
Line 29: from vdsm import qemuimg
Line 30: from vdsm.storage import exception as se


-- 
To view, visit https://gerrit.ovirt.org/54564
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccde03ea2fb77fb2df24de59b61952578b3f1fc3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list