Change in vdsm[master]: sd: Introduce StorageDomainChecker

alitke at redhat.com alitke at redhat.com
Mon Mar 14 14:14:39 UTC 2016


Adam Litke has posted comments on this change.

Change subject: sd: Introduce StorageDomainChecker
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/54375/2/tests/manifest_tests.py
File tests/manifest_tests.py:

Line 36
Line 37
Line 38
Line 39
Line 40
You will need to add tests for the checker.


https://gerrit.ovirt.org/#/c/54375/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 420:         if now - self._last_vg_check > timeout:
Line 421:             self._last_vg_check = now
Line 422:             lvm.chkVG(self._sd_uuid)
Line 423:         elif lvm.getVG(self._sd_uuid).partial != lvm.VG_OK:
Line 424:             raise se.StorageDomainAccessError(self._sd_uuid)
It's not obvious to me how simply moving the same checks from the BlockSD into this class is improving the situation.  Aren't you still refreshing the data with the same interval (repo_stats_cache_refresh_timeout)?
Line 425: 
Line 426:     def stats(self):
Line 427:         return vg_stats(self._sd_uuid)
Line 428: 


-- 
To view, visit https://gerrit.ovirt.org/54375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib801c54515baaa6b04098f97c8df70c711535200
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list