Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system

edwardh at redhat.com edwardh at redhat.com
Mon Mar 14 12:57:36 UTC 2016


Edward Haas has posted comments on this change.

Change subject: Skipping networkTests if alien bonds presents in the system
......................................................................


Patch Set 8:

(2 comments)

nits

https://gerrit.ovirt.org/#/c/53498/8/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 222: config
Just cleanup stuff: rename to bare_running_config


Line 231:     running_config = normalized_running_config.as_unicode()
        :     kernel_config = bare_kernel_config.as_unicode()
        :     return (running_config, kernel_config)
just return it directly:

return normalized_running_config.as_unicode(), bare_kernel_config.as_unicode()


-- 
To view, visit https://gerrit.ovirt.org/53498
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ilia Meerovich <iliam at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ilia Meerovich <iliam at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list