Change in vdsm[master]: vm: simplify setCpu* methods

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Mar 14 09:41:03 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: vm: simplify setCpu* methods
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

-1 for visibility of the exception message issue, otherwise nice simplification

https://gerrit.ovirt.org/#/c/54665/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3989:     def _setCpuTuneValue(self, **kwargs):
Line 3990:         try:
Line 3991:             self._dom.setSchedulerParameters(kwargs)
Line 3992:         except ValueError:
Line 3993:             raise exception.CpuTuneError('an integer is required for period')
period or quota - I would suggest to change the message to 'An integer argument is required'
Line 3994:         except libvirt.libvirtError as e:
Line 3995:             raise exception.CpuTuneError(e.message)
Line 3996: 
Line 3997:         try:


-- 
To view, visit https://gerrit.ovirt.org/54665
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72c5efcbfbd7f37a0d77cba0ebf9f8fa01936d29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list