Change in vdsm[master]: osinfo: use pep8 function names

mpolednik at redhat.com mpolednik at redhat.com
Mon Mar 14 09:34:27 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: osinfo: use pep8 function names
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54543/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:

Line 92: _release
> maybe that's me, but this reminds me more Semaphore.release() than a softwa
I'm trying to avoid duplicating the information that we're dealing with OS in the function name, so not sure about the suggested name. I think _release_name is unambiguous. Any other suggestions are welcome!


-- 
To view, visit https://gerrit.ovirt.org/54543
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list