Change in vdsm[master]: Moving PAGE_SIZE_BYTES to utils

mpolednik at redhat.com mpolednik at redhat.com
Mon Mar 14 08:47:24 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: Moving PAGE_SIZE_BYTES to utils
......................................................................


Patch Set 3: Code-Review-1

I have to agree with the big yes, but also that I myself have issues choosing it's destination. I was thinking osinfo module initially (the one in review currently) but that doesn't make too much sense as this is really architectural, not OS thing. My vote would be either cpuarch or host.py. Let's keep cpuinfo out of this as it is very closely tied to the cpuinfo file.

-- 
To view, visit https://gerrit.ovirt.org/54155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ca893f4cfb14c67788d96a0ced96e6325f0d0c5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list