Change in vdsm[master]: net tests: Introduce Router Advertisement with dnsmasq

danken at redhat.com danken at redhat.com
Sun Mar 13 18:46:09 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Introduce Router Advertisement with dnsmasq
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54630/2/tests/functional/dhcp.py
File tests/functional/dhcp.py:

Line 66:                                                          dhcp_range_to)]
Line 67:         if dhcpv6_range_from and dhcpv6_range_to:
Line 68:             command += ['--dhcp-range={0},{1},2m'.format(dhcpv6_range_from,
Line 69:                                                          dhcpv6_range_to)]
Line 70:         if ipv6_slaac_prefix:
I still do not understand the semantics of this. there's intentionally no _to bound?!
What is slaac prefix? and why do you ignore its value when it is not None?
Line 71:             command += ['--enable-ra']
Line 72:             command += ['--dhcp-range={0},slaac,2m'.format(dhcpv6_range_from)]
Line 73: 
Line 74:         self.proc = execCmd(command, sync=False)


-- 
To view, visit https://gerrit.ovirt.org/54630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If770736e899c5e8e5e9086237876b6c0ec74b6ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list