Change in vdsm[master]: storage: Move sync module to lib

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 13 11:56:26 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: Move sync module to lib
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

Ala, can you verify this?

https://gerrit.ovirt.org/#/c/54596/6/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 36: from vdsm import supervdsm
Line 37: from vdsm import udevadm
Line 38: from vdsm import utils
Line 39: from vdsm.storage import exception as se
Line 40: from vdsm.storage import sync
This is nicer, but when we move module, we should avoid such changes, as this can easily break the code.

Please do not changed the code when you move modules. If you want to improve it do this in a separate patch.
Line 41: 
Line 42: import mount
Line 43: import fileUtils
Line 44: import fileSD


-- 
To view, visit https://gerrit.ovirt.org/54596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94deeaa91f8ba0792d2b7f1b733b5615b6dfc51e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list