Change in vdsm[master]: tests: refactor manifest_tests fake env setup

alitke at redhat.com alitke at redhat.com
Fri Mar 11 21:44:03 UTC 2016


Adam Litke has posted comments on this change.

Change subject: tests: refactor manifest_tests fake env setup
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50273/2/tests/domain_manifest_tests.py
File tests/domain_manifest_tests.py:

Line 110:         with fake_block_env() as env:
Line 111:             self.assertEquals(512, env.sd_manifest.logBlkSize)
Line 112:             self.assertEquals(512, env.sd_manifest.phyBlkSize)
Line 113: 
Line 114:     def test_overwrite_blocksize(self):
> Is this new test? can we add it separately?
sure
Line 115:         metadata = {sd.DMDK_VERSION: 3,
Line 116:                     blockSD.DMDK_LOGBLKSIZE: 2048,
Line 117:                     blockSD.DMDK_PHYBLKSIZE: 1024}
Line 118:         with fake_block_env() as env:


-- 
To view, visit https://gerrit.ovirt.org/50273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74b82ffaa34d6df68e1531735cc776e4de23f95c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list