Change in vdsm[master]: tests: Add readers contention rwlock test
alitke at redhat.com
alitke at redhat.com
Fri Mar 11 14:48:38 UTC 2016
Adam Litke has posted comments on this change.
Change subject: tests: Add readers contention rwlock test
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/51923/3/tests/rwlock_test.py
File tests/rwlock_test.py:
Line 305:
Line 306: print()
Line 307: avg_reads, med_reads, min_reads, max_reads = stats(reads)
Line 308: print("reads avg=%.2f med=%d min=%d max=%d"
Line 309: % (avg_reads, med_reads, min_reads, max_reads))
You're not checking for any condition. What is this actually testing then? I see it's useful to print stats but no one is regularly reading the output of passed tests.
Line 310:
Line 311:
Line 312: def stats(seq):
Line 313: seq = sorted(seq)
--
To view, visit https://gerrit.ovirt.org/51923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list