Change in vdsm[master]: net: legacy: split bonds handling to removal and setup
danken at redhat.com
danken at redhat.com
Thu Mar 10 20:59:41 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: net: legacy: split bonds handling to removal and setup
......................................................................
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/54352/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 220: bonds_removal
-naming nit: please use verbs, as done with networks: remove_bonds; add_bonds
https://gerrit.ovirt.org/#/c/54352/2/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:
Line 591:
Line 592: return True
Line 593:
Line 594:
Line 595: def _bonds_edit_remove(bonds, configurator, _netinfo):
this function name is a bit vague. please add a little docstring.
Line 596: _netinfo.updateDevices()
Line 597:
Line 598: for name, attrs in six.iteritems(bonds):
Line 599: slaves_to_remove = (set(_netinfo.bondings[name]['slaves']) -
Line 608: slave = Nic(name, configurator, _netinfo=_netinfo)
Line 609: slave.remove(remove_even_if_used=True)
Line 610:
Line 611:
Line 612: def _bonds_edit_add(bonds, configurator, _netinfo):
here too, please
Line 613: _netinfo.updateDevices()
Line 614:
Line 615: for name, attrs in six.iteritems(bonds):
Line 616: bond = Bond.objectivize(
--
To view, visit https://gerrit.ovirt.org/54352
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53d04c89a72d514ffcea93981b6782f6eb4a14d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list