Change in vdsm[master]: lib: executor: port executor.py to python3

fromani at redhat.com fromani at redhat.com
Thu Mar 10 16:03:53 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: lib: executor: port executor.py to python3
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/54576/3/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 70
Line 71
Line 72
Line 73
Line 74
> Is this the only xrange? In this case it is better to replace it with range
there is another one on line 82. Exactly two of them.
I agree that using range() is probably simpler.


-- 
To view, visit https://gerrit.ovirt.org/54576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b768b4a7f297f59376e005b4abab3a328bf4b50
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list