Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

edwardh at redhat.com edwardh at redhat.com
Thu Mar 10 14:04:25 UTC 2016


Edward Haas has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:

> Other configurators will follow, they should adapt the added function only 
I would recommend considering that when it will be needed, not now. At the moment it just looks redundant.
Line 1: # Copyright 2013-2014 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list