Change in vdsm[master]: net: IP address hostport split tool

frolland at redhat.com frolland at redhat.com
Thu Mar 10 09:27:19 UTC 2016


Freddy Rolland has posted comments on this change.

Change subject: net: IP address hostport split tool
......................................................................


Patch Set 4:

I tend to agree that this tool should be in a common space.
We should try to separate the packages. Adding more dependencies will make it harder in the future to separate the processes.
We could have for utilities:
lib/vdsm/common
lib/vdsm/common/network
lib/vdsm/common/storage
lib/vdsm/common/virt
In that way responsibility will be clear.

Also moving all the modules from lib/vdsm to lib/vdsm/common will make everything cleaner.

-- 
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list