Change in vdsm[master]: virt: Use PEP8 identifiers in vmxml.device_address

fromani at redhat.com fromani at redhat.com
Thu Mar 10 08:07:11 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Use PEP8 identifiers in vmxml.device_address
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Please check inline comments.

https://gerrit.ovirt.org/#/c/54511/1/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 67:     """
Line 68:     Obtain device's address from libvirt
Line 69:     """
Line 70:     address = {}
Line 71:     adr_xml = dev_xml.getElementsByTagName('address')[index]
> adr_xml is to cryptic, better use address_xml or the common addr_xml.
+1
Line 72:     # Parse address to create proper dictionary.
Line 73:     # Libvirt device's address definition is:
Line 74:     # PCI = {'type':'pci', 'domain':'0x0000', 'bus':'0x00',
Line 75:     #        'slot':'0x0c', 'function':'0x0'}


-- 
To view, visit https://gerrit.ovirt.org/54511
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75ec0bcef132bd8b5bd40bb5f4859578014e2728
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list