Change in vdsm[master]: net: IP address hostport split tool

danken at redhat.com danken at redhat.com
Thu Mar 10 07:04:13 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: IP address hostport split tool
......................................................................


Patch Set 4:

Nir, the storage "vertical" can (and does) give services to other verticals (mount.Mount is an example). Similarly, network-related code can sit in the network subpackage, be owned by network people, but still be used be used by other but of the code (gluster and virt use netinfo functions).

Where would you suggest to place this new function? in the "utils" junkyard? or maybe in a new utils.net subpackage?

-- 
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list