Change in vdsm[master]: storagetests: initial FakeEnv support

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 9 22:33:33 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storagetests: initial FakeEnv support
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Looks good, minor style issue.

https://gerrit.ovirt.org/#/c/54567/1/tests/storagetestlib.py
File tests/storagetestlib.py:

Line 56:     with namedTemporaryDir() as tmpdir:
Line 57:         lvm = FakeLVM(tmpdir)
Line 58:         with MonkeyPatchScope([(blockSD, 'lvm', lvm),
Line 59:                                (blockVolume, 'lvm', lvm),
Line 60:                                (sd, 'storage_repository', tmpdir)]):
Lets keep the same style for MonkeyPatchScope lists. The version you used above is more flexible, supporting longer lines, so lets use it.
Line 61:             sd_manifest = make_blocksd(tmpdir, lvm)
Line 62:             yield FakeEnv(sd_manifest, lvm=lvm)
Line 63: 
Line 64: 


-- 
To view, visit https://gerrit.ovirt.org/54567
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c27ad8f642639852796ab98fb102dedf55aedd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list