Change in vdsm[master]: tests: incorporate pool id in file domain path

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 9 22:29:49 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: incorporate pool id in file domain path
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Looks good, imports can be nicer.

https://gerrit.ovirt.org/#/c/54565/1/tests/domain_manifest_tests.py
File tests/domain_manifest_tests.py:

Line 23: from testlib import VdsmTestCase, namedTemporaryDir, make_file, recorded
Line 24: from monkeypatch import MonkeyPatchScope
Line 25: from storagefakelib import FakeLVM
Line 26: from storagetestlib import make_filesd_manifest, make_blocksd, \
Line 27:     make_file_volume, DOM_VER
These long import are hard to work with, lets use one line per import, or import a list of modules:

from xxx import (
   yyy,
   zzz
   ...
)
Line 28: 
Line 29: from storage import sd, blockSD, blockVolume
Line 30: 
Line 31: VOLSIZE = 1048576


-- 
To view, visit https://gerrit.ovirt.org/54565
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bac433a081b058eec4e1897ea85e698850abb2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list