Change in vdsm[master]: vm: remove unused sendKeys verb

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Wed Mar 9 09:56:53 UTC 2016


Piotr Kliczewski has uploaded a new change for review.

Change subject: vm: remove unused sendKeys verb
......................................................................

vm: remove unused sendKeys verb


Change-Id: I709610a43cdf58464147ed6c7167d93558e29451
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/rpc/bindingxmlrpc.py
M vdsm/API.py
4 files changed, 0 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/54514/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index a4f55e5..c479f68 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -497,10 +497,6 @@
         print(response['status']['message'])
         sys.exit(response['status']['code'])
 
-    def do_sendkeys(self, args):
-        vmId = args[0]
-        return self.ExecAndExit(self.s.sendkeys(vmId, args[1:]))
-
     def hibernate(self, args):
         vmId, hiberVolHandle = args[0], args[1]
         response = self.s.hibernate(vmId, hiberVolHandle)
@@ -2218,10 +2214,6 @@
                           ('<vmId>',
                            '(not implemented) cancel machine migration'
                            )),
-        'sendkeys': (serv.do_sendkeys,
-                     ('<vmId> <key1> ...... <keyN>',
-                      'Send the key sequence to the vm'
-                      )),
         'getVdsCapabilities': (serv.do_getCap,
                                ('',
                                 'Get Capabilities info of the VDS'
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index 215ce13..8882cd8 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -7982,22 +7982,6 @@
  'data': {'vmID': 'UUID'}}
 
 ##
-# @VM.sendKeys:
-#
-# Send a string of keys to a guest's keyboard.
-#
-# @vmID:         The UUID of the VM
-#
-# @keySequence:  A sequence of keystrokes to send
-#
-# Since: 4.10.0
-#
-# Notes:  This function is not implemented.
-##
-{'command': {'class': 'VM', 'name': 'sendKeys'},
- 'data': {'vmID': 'UUID', 'keySequence': 'str'}}
-
-##
 # @VmTicketConflictAction:
 #
 # An enumeration of consequences if another user is connected to a display.
diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py
index f220c8d..8850634 100644
--- a/lib/vdsm/rpc/bindingxmlrpc.py
+++ b/lib/vdsm/rpc/bindingxmlrpc.py
@@ -433,10 +433,6 @@
         vm = API.VM(vmId)
         return vm.changeFloppy(driveSpec)
 
-    def vmSendKeys(self, vmId, keySequence):
-        vm = API.VM(vmId)
-        return vm.sendKeys(keySequence)
-
     def vmMigrate(self, params):
         vm = API.VM(params['vmId'])
         return vm.migrate(params)
@@ -1056,7 +1052,6 @@
                 (self.vmSetTicket, 'setVmTicket'),
                 (self.vmChangeCD, 'changeCD'),
                 (self.vmChangeFloppy, 'changeFloppy'),
-                (self.vmSendKeys, 'sendkeys'),
                 (self.vmMigrate, 'migrate'),
                 (self.vmGetMigrationStatus, 'migrateStatus'),
                 (self.vmMigrationCancel, 'migrateCancel'),
diff --git a/vdsm/API.py b/vdsm/API.py
index 2e772d4..a625972 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -650,14 +650,6 @@
         """
         return errCode['noimpl']
 
-    def sendKeys(self, keySequence):
-        """
-        Send a string of keys to a guest's keyboard (OBSOLETE)
-
-        Used only by QA and might be discontinued in next version.
-        """
-        return errCode['noimpl']
-
     def setTicket(self, password, ttl, existingConnAction, params):
         """
         Set the ticket (password) to be used to connect to a VM display


-- 
To view, visit https://gerrit.ovirt.org/54514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I709610a43cdf58464147ed6c7167d93558e29451
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>


More information about the vdsm-patches mailing list