Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm

mzamazal at redhat.com mzamazal at redhat.com
Wed Mar 9 09:44:09 UTC 2016


Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/53619/8/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 173:                     if tlsPort:
Line 174:                         dev['tlsPort'] = tlsPort
Line 175:                     break
Line 176: 
Line 177:         # the first graphic device is duplicated in the legacy conf
> let's add (maybe in a future patch) a comment to remind us that this should
IMO the comment is not worth a separate patch, added here.
Line 178:         updateLegacyConf({'devices': vm.conf['devices']})
Line 179: 
Line 180: 
Line 181: def isSupportedDisplayType(vmParams):


-- 
To view, visit https://gerrit.ovirt.org/53619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list