Change in vdsm[master]: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py

mzamazal at redhat.com mzamazal at redhat.com
Wed Mar 9 09:39:53 UTC 2016


Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/53615/5/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 62:             alias = aliasElement[0].getAttribute('name')
Line 63:             yield deviceXML, alias
Line 64: 
Line 65: 
Line 66: def device_address(devXml, index=0):
> minor: let's reformat in pep8 style. It is fine for me if you do now or int
> minor: let's reformat in pep8 style.

Done in a followup patch.

> also, let's make sure this code is covered by tests

It is covered.
Line 67:     """
Line 68:     Obtain device's address from libvirt
Line 69:     """
Line 70:     address = {}


-- 
To view, visit https://gerrit.ovirt.org/53615
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9868ca1df6650b1262e6f30d639a08b1f38304d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list