Change in vdsm[master]: storage: Move storage_exception module to lib

frolland at redhat.com frolland at redhat.com
Wed Mar 9 08:18:15 UTC 2016


Freddy Rolland has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
......................................................................


Patch Set 6:

(7 comments)

https://gerrit.ovirt.org/#/c/54467/6/debian/vdsm-python.install
File debian/vdsm-python.install:

Line 61: ./usr/lib/python2.7/dist-packages/vdsm/sslutils.py
Line 62: ./usr/lib/python2.7/dist-packages/vdsm/storage/__init__.py
Line 63: ./usr/lib/python2.7/dist-packages/vdsm/storage/constants.py
Line 64: ./usr/lib/python2.7/dist-packages/vdsm/storage/securable.py
Line 65: ./usr/lib/python2.7/dist-packages/vdsm/storage/storage_exception.py
> Since we are renaming the file (moving), this is good time to rename it to 
Done
Line 66: ./usr/lib/python2.7/dist-packages/vdsm/supervdsm.py
Line 67: ./usr/lib/python2.7/dist-packages/vdsm/taskset.py
Line 68: ./usr/lib/python2.7/dist-packages/vdsm/tool/__init__.py
Line 69: ./usr/lib/python2.7/dist-packages/vdsm/tool/dummybr.py


https://gerrit.ovirt.org/#/c/54467/6/lib/vdsm/storage/Makefile.am
File lib/vdsm/storage/Makefile.am:

Line 24: dist_vdsmstorage_PYTHON = \
Line 25: 	__init__.py \
Line 26: 	constants.py \
Line 27: 	securable.py \
Line 28: 	storage_exception.py \
> exception.py
Done


https://gerrit.ovirt.org/#/c/54467/6/tests/blockVolumeTests.py
File tests/blockVolumeTests.py:

Line 19: #
Line 20: 
Line 21: 
Line 22: from vdsm.config import config
Line 23: from vdsm.storage import storage_exception as se
> from vdsm.storage import exception as se
Done
Line 24: 
Line 25: from storage.blockVolume import BlockVolume
Line 26: from storage import volume
Line 27: from testlib import permutations, expandPermutations


https://gerrit.ovirt.org/#/c/54467/6/tests/main.py
File tests/main.py:

Line 22
Line 23
Line 24
Line 25
Line 26
> The storage import should be here.
Done


Line 22: import unittest
Line 23: 
Line 24: from gluster import exception as gluster_exception
Line 25: 
Line 26: from vdsm.storage import storage_exception
> Lets do like gluster here:
Done
Line 27: from vdsm.exception import GeneralException
Line 28: 
Line 29: from testlib import VdsmTestCase as TestCaseBase
Line 30: 


https://gerrit.ovirt.org/#/c/54467/6/vdsm/storage/storage_mailbox.py
File vdsm/storage/storage_mailbox.py:

Line 27
Line 28
Line 29
Line 30
Line 31
> Here
Done


Line 34: import sd
Line 35: import misc
Line 36: import task
Line 37: from threadPool import ThreadPool
Line 38: from vdsm.storage.storage_exception import InvalidParameterException
> This should move under vdsm.config import.
Done
Line 39: from vdsm import concurrent
Line 40: from vdsm import constants
Line 41: 
Line 42: __author__ = "ayalb"


-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list