Change in vdsm[master]: virt-sparsify: add inplace virt-sparsify support
nsoffer at redhat.com
nsoffer at redhat.com
Tue Mar 8 17:05:31 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: virt-sparsify: add inplace virt-sparsify support
......................................................................
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/54427/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 8275
Line 8276
Line 8277
Line 8278
Line 8279
Unrelated
Line 8711: 'storagedomainID': 'UUID', 'imageID': 'UUID',
Line 8712: 'legality': 'VolumeLegality'}}
Line 8713:
Line 8714: ##
Line 8715: # @Volume.sparsifyInplace:
Should be:
@Volume.sparsify
Line 8716: #
Line 8717: # Perform an in-place sparse (e.g. not creating a new image) on given volume
Line 8718: #
Line 8719: # @volumeID: The UUID of the Volume
Line 8715: # @Volume.sparsifyInplace:
Line 8716: #
Line 8717: # Perform an in-place sparse (e.g. not creating a new image) on given volume
Line 8718: #
Line 8719: # @volumeID: The UUID of the Volume
Use the new style names as used by new sdm verbs:
vol_id
pool_id
dom_id
img_id
See SDM.create_volume.
In new verbs, we do not use the pool id - but I'm not sure we can avoid this in 4.0. Adding Adam to review this.
Also, the order of the parameter must be:
pool > domain > image > volume
Old verbs are a mess, lest not repeat these errors.
Line 8720: #
Line 8721: # @storagepoolID: The UUID of the image that contains the volume
Line 8722: #
Line 8723: # @storagedomainID: The Storage Pool UUID associated with the Volume
Line 8925: # @SDM:
Line 8926: #
Line 8927: # This namespace is for SDM (storage domain manager) functions.
Line 8928: #
Line 8929: # Since: 4.19
How is this change related to your patch?!
This original version is correct, 4.18 is the next version (ovirt-4.0)
Line 8930: ##
Line 8931: {'class': 'SDM'}
Line 8932:
Line 8933: ##
https://gerrit.ovirt.org/#/c/54427/1/lib/vdsm/Makefile.am
File lib/vdsm/Makefile.am:
Line 62: udevadm.py \
Line 63: utils.py \
Line 64: v2v.py \
Line 65: vdscli.py \
Line 66: virtsparsify.py \
This is not a wrapper for virt-sparcify, so we should not call it virt-sparcify. It it the implementation of Vdsm's sparcify() verb, so the module name should be sparcify.py
Line 67: xmlrpc.py \
Line 68: $(NULL)
Line 69:
Line 70: nodist_vdsmpylib_PYTHON = \
--
To view, visit https://gerrit.ovirt.org/54427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a1269d71816a8ab25c4a00bfb483620cfefde8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list