Change in vdsm[master]: storage: Move storage_exception module to lib

frolland at redhat.com frolland at redhat.com
Tue Mar 8 15:51:41 UTC 2016


Freddy Rolland has posted comments on this change.

Change subject: storage: Move storage_exception module to lib
......................................................................


Patch Set 4:

(8 comments)

https://gerrit.ovirt.org/#/c/54467/4/tests/functional/storageTests.py
File tests/functional/storageTests.py:

Line 42: from vdsm.config import config
Line 43: from vdsm.constants import VDSM_USER, VDSM_GROUP
Line 44: from vdsm.storage import storage_exception as se
Line 45: from vdsm.utils import CommandPath, RollbackContext
Line 46: from vdsm.virt import vmstatus
> Please revert this import cleanup and do it in another patch.
Done
Line 47: 
Line 48: import storage.sd
Line 49: import storage.volume
Line 50: from storage.misc import execCmd


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 30: from vdsm import utils
Line 31: from vdsm.config import config
Line 32: from vdsm.storage import storage_exception as se
Line 33: 
Line 34: import misc
> Please avoid this unrelated changes like misc and vdsm.confg imports.
Done
Line 35: 
Line 36: 
Line 37: MAX_HOST_ID = 250
Line 38: 


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 27: import re
Line 28: 
Line 29: from vdsm import constants
Line 30: from vdsm import supervdsm
Line 31: from vdsm.storage import storage_exception as se
> This should be the only import changed in this patch, mixing this with impo
Done
Line 32: from vdsm.storage.constants import LEASE_FILEEXT
Line 33: from vdsm.utils import stripNewLines
Line 34: 
Line 35: import sd


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/glusterSD.py
File vdsm/storage/glusterSD.py:

Line 15: # along with this program; if not, write to the Free Software
Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
> Unrelated change, please add in a separate patch.
Done
Line 20: 
Line 21: import os
Line 22: 
Line 23: from vdsm.storage import storage_exception as se


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/imageSharing.py
File vdsm/storage/imageSharing.py:

Line 20: import logging
Line 21: import signal
Line 22: 
Line 23: from vdsm import commands
Line 24: from vdsm import constants
> Unrelated
Done
Line 25: from vdsm.storage import storage_exception as se
Line 26: 
Line 27: import curlImgWrap
Line 28: 


Line 23: from vdsm import commands
Line 24: from vdsm import constants
Line 25: from vdsm.storage import storage_exception as se
Line 26: 
Line 27: import curlImgWrap
> Unrelated
Done
Line 28: 
Line 29: 
Line 30: log = logging.getLogger("Storage.ImageSharing")
Line 31: # Time to wait from finishing writing data to dd, until dd exists,


https://gerrit.ovirt.org/#/c/54467/4/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:

Line 28: from Queue import Queue
Line 29: 
Line 30: from vdsm import concurrent
Line 31: from vdsm import utils
Line 32: from vdsm.logUtils import SimpleLogAdapter
> Unrelated
Done
Line 33: from vdsm.storage import storage_exception as se
Line 34: 
Line 35: import misc
Line 36: 


Line 31: from vdsm import utils
Line 32: from vdsm.logUtils import SimpleLogAdapter
Line 33: from vdsm.storage import storage_exception as se
Line 34: 
Line 35: import misc
> Unrelated
Done
Line 36: 
Line 37: 
Line 38: # Errors
Line 39: 


-- 
To view, visit https://gerrit.ovirt.org/54467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4995df5a670ca9bd460043d44d2855eb64a78f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list